Skip to content

Update requirements-schemaregistry.txt - authlib min version #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yairm210
Copy link

What

Recent changes have added an authlib dependency to schema registry code - specifically, from authlib.integrations.httpx_client import OAuth2Client

This is code that does not exist in older authlib versions (added here) and thus will break on import, if confluent_kafka is added to a repo which already contains an older version of authlib, since it "satisfies the dependency".
Theoretically one can use authlib >= 0.13.0, but since the next couple of versions are all "fix httpx", the first version I would trust to not break compatibility with what you tested would be version 1.0.0.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • Tested the min version, this adds no new code

References

Test & Review

Tested both import and usage with 1.0.0, works fine

@yairm210 yairm210 requested review from a team as code owners April 23, 2025 07:45
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Apr 23, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ yairm210
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@rayokota
Copy link
Member

/sem-approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants