[KIP-460] ElectLeaders implementation public API changes and documentation improvement #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emasab
commented
Oct 10, 2024
emasab
commented
- ElectionType in confluent_kafka as in Java
- dictionary value is a KafkaError as it's not thrown
- ElectionType should be added to documentation .rst
- docstring changes
- tests without brokers with successful validation that leads to a timeout
- example elects leaders for all partitions in case no partition is specified
…ation improvement - ElectionType confluent_kafka as in Java - dictionary value is a KafkaError as it's not thrown - ElectionType should be added to documentation .rst - docstring changes - tests without brokers with successful validation that leads to a timeout - example elects leaders for all partitions in case no partition is specified
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.