Skip to content

Add linux ARM64 wheels block in Semaphore #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Add linux ARM64 wheels block in Semaphore #1496

merged 1 commit into from
Feb 6, 2023

Conversation

anchitj
Copy link
Member

@anchitj anchitj commented Jan 10, 2023 •
edited
Loading

Added block in semaphore to build wheels for Linux Arm64.

cibuildwheel isn't working, as the wheel generated from it weren't installable. So generating the wheels thorugh recompiling librdkafka and using the manual wheel building script.

@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch from 80acadc to 43e68cf Compare January 10, 2023 06:58
@pranavrth
Copy link
Member

We want to generate Linux arm64 wheels. x64 wheels generation is already present in Travis job for now.

@anchitj
Copy link
Member Author

anchitj commented Jan 10, 2023

We want to generate Linux arm64 wheels. x64 wheels generation is already present in Travis job for now.

Yeah, I'm right now testing the x64 itself through this draft PR as it's failing. Will update the PR to in review state once it's ready.

@anchitj anchitj changed the title Add linux x64 wheel script [WIP]Add linux x64 wheel script Jan 10, 2023
@pranavrth
Copy link
Member

We want to generate Linux arm64 wheels. x64 wheels generation is already present in Travis job for now.

Yeah, I'm right now testing the x64 itself through this draft PR as it's failing. Will update the PR to in review state once it's ready.

Oh. I thought you got confused b/w x64 and arm64. Carry on.

@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch 24 times, most recently from 7dc3a94 to 52b55d1 Compare January 16, 2023 11:31
@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch from 0b75918 to b1e9950 Compare January 18, 2023 09:47
@emasab
Copy link
Contributor

emasab commented Feb 2, 2023

@anchitj yes, please add a changelog entry because it's something that simplifies the client's installation

@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch 11 times, most recently from 744d37b to a73f93c Compare February 2, 2023 18:05
@anchitj anchitj requested review from emasab and pranavrth February 3, 2023 09:58
emasab
emasab reviewed Feb 3, 2023
View reviewed changes
emasab
emasab requested changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run only on tags there

emasab
emasab requested changes Feb 3, 2023
View reviewed changes
@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch 2 times, most recently from 9ad1775 to b389355 Compare February 3, 2023 16:48
@anchitj anchitj force-pushed the anchit/SemaphoreLinuxWheels branch from b389355 to 9583ccc Compare February 3, 2023 17:25
emasab
emasab approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Anchit! I've verified the wheel on Linux / arm64 too and it works correctly, with SSL too.

@anchitj anchitj merged commit 6a3f438 into master Feb 6, 2023
@anchitj anchitj deleted the anchit/SemaphoreLinuxWheels branch February 6, 2023 11:42
@mauriciogardini
Copy link

Hello, sorry to "reopen" this, but I am not seeing the Linux arm64 wheel on pypi: https://pypi.org/simple/confluent-kafka/

Is this expected?

@anchitj
Copy link
Member Author

anchitj commented Feb 9, 2023

@mauriciogardini They will be available with the next release.

@mauriciogardini
Copy link

Thanks, @anchitj !

@pranavrth pranavrth mentioned this pull request Mar 10, 2023
Closed
7 tasks
@chriselion chriselion mentioned this pull request Apr 20, 2023
Closed
7 tasks
emasab pushed a commit that referenced this pull request Jun 19, 2023
@anchitj @emasab
Add linux ARM64 wheels block in Semaphore (#1496)
9dcffcf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

@PrasanthV454 PrasanthV454 Awaiting requested review from PrasanthV454

@pranavrth pranavrth Awaiting requested review from pranavrth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anchitj @pranavrth @emasab @mauriciogardini