fix sid generation in cookie middleware

[yani]

I had to change this in order for sid generation to work.

Is there a specific reason for using the translated native sid generation from the session extension?
I feel a normal random string generator would be better. And ignore session.sid_length and session.sid_bits_per_character.

[compwright]

Is there a specific reason for using the translated native sid generation from the session extension?

I'm confused by your question, can you elaborate?

[yani]

Is there a specific reason for using the translated native sid generation from the session extension?

I'm confused by your question, can you elaborate?

Why doesn't SessionId->create_sid() use a simple string generator instead of the bits and bytes way of doing it?

(I have this coded btw, have a look at: 9b8e5e5
I even have a nice PR pre-written for it :))

[compwright]

@yani it's done that way because that's how https://www.php.net/manual/en/function.session-create-id.php does it