Skip to content

psr/simple-cache v3 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yani opened this issue Dec 19, 2022 · 6 comments · Fixed by #8
Closed

psr/simple-cache v3 #2

yani opened this issue Dec 19, 2022 · 6 comments · Fixed by #8
Labels
bug Something isn't working

Comments

@yani
Copy link
Contributor

yani commented Dec 19, 2022

I'm trying to use the package in a project that already uses psr/simple-cache v3. For me personally it isn't much of a problem as I fork for the time being.

  Problem 1
    - Root composer.json requires compwright/php-session ^1.2 -> satisfiable by compwright/php-session[1.2.0, 1.2.1, 1.2.2, 1.2.3].
    - compwright/php-session[1.2.0, ..., 1.2.3] require psr/simple-cache ^1 -> found psr/simple-cache[1.0.0, 1.0.1] but it conflicts with your root composer.json require (^3.0).

I would be nice to upgrade this package to v3 but I don't know how easy an upgrade would be.

After updating psr/simple-cache:

   DEPRECATED  Return type of Compwright\PhpSession\Handlers\Psr16Handler::read($id) should either be compatible with SessionHandlerInterface::read(string $id): string|false, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor\compwright\php-session\src\Handlers\Psr16Handler.php on line 54.


   DEPRECATED  Return type of Compwright\PhpSession\Handlers\Psr16Handler::gc($max_lifetime): bool should either be compatible with SessionHandlerInterface::gc(int $max_lifetime): int|false, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor\compwright\php-session\src\Handlers\Psr16Handler.php on line 97.
@compwright
Copy link
Owner

Fixed in v1.2.4

@compwright
Copy link
Owner

@yani 1.2.4 upgrades dependencies, however it is evident that more work is needed.

@compwright compwright reopened this Dec 19, 2022
@yani
Copy link
Contributor Author

yani commented Dec 19, 2022

@compwright Yeah I was also looking into it and odan/cache:0.5.0 requires psr/simple-cache:1.0 and has no update yet.

@compwright
Copy link
Owner

@yani fixed in v2.0.0

@compwright
Copy link
Owner

By the way thank you for using this library! I'd love to hear more about your use case, and how it goes.

@compwright compwright added the bug Something isn't working label Dec 19, 2022
@yani
Copy link
Contributor Author

yani commented Dec 20, 2022

I'll implement v2 and play around with it :) Thanks for updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants