Skip to content

Skip more steps if Android is disabled #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Skip more steps if Android is disabled #906

merged 1 commit into from
Feb 27, 2025

Conversation

Steelskin
Copy link
Collaborator

This speeds up the no-Android builds by disabling unneeded downloads and repo syncs.

compnerd
compnerd approved these changes Feb 26, 2025
View reviewed changes
Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. I wonder if we can hoist the Android check into a variable computed once for readability.

@Steelskin Steelskin force-pushed the fabrice/skip-steps-no-android branch from 544cb1b to edd1f93 Compare February 27, 2025 17:38
@Steelskin Steelskin merged commit 3f52be8 into main Feb 27, 2025
1 check passed
@Steelskin Steelskin deleted the fabrice/skip-steps-no-android branch February 27, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@hjyamauchi hjyamauchi hjyamauchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steelskin @compnerd @hjyamauchi