GHA: simplify the compiler context #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjyamauchi
approved these changes
Feb 6, 2025
compnerd
force-pushed
the
compnerd/context
branch
from
3965ad1 to
453010b
Compare
With the removal of the runtimes build in unified build, we are able to universally inline some of the computation of the flags. Other options are no longer required to be evaluated at build time. Re-order some of the options to similarly order the macOS and Windows builds.
hjyamauchi
force-pushed
the
compnerd/context
branch
from
453010b to
877d4ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of the runtimes build in unified build, we are able to universally inline some of the computation of the flags. Other options are no longer required to be evaluated at build time. Re-order some of the options to similarly order the macOS and Windows builds.