Skip to content

[devtools] Add swift-lmdb to the devtools job #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

Steelskin
Copy link
Collaborator

swift-lmdb is now a required dependency of IndexStoreDB.

Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to pipe that into DocC-SymbolKit and SourceKit-LSP as well.

@Steelskin Steelskin force-pushed the fabrice/devtools-build-swift-lmdb branch 2 times, most recently from 052a7c5 to c92a0b5 Compare December 19, 2024 16:18
@Steelskin Steelskin marked this pull request as ready for review December 20, 2024 01:12
@Steelskin Steelskin requested a review from compnerd December 20, 2024 01:12
Copy link
Collaborator Author

@Steelskin Steelskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compnerd PTAL
As I mentioned, I had to add this to a couple of build tasks to workaround a linker bug:

-Xfrontend -disable-round-trip-debug-type

Let me know if you'd rather try fixing that problem separately. I got a green build with this PR.

@compnerd
Copy link
Owner

Yeah, I think that we should try to debug that problem separately. If we can identify where it got introduced, we should be able to revert it. But the fact that we are building this in CI and not hitting it there is suspicious.

swift-lmdb is now a required dependency of IndexStoreDB.
@Steelskin Steelskin force-pushed the fabrice/devtools-build-swift-lmdb branch from c92a0b5 to 9f49e79 Compare December 20, 2024 17:53
@Steelskin
Copy link
Collaborator Author

Yeah, I think that we should try to debug that problem separately. If we can identify where it got introduced, we should be able to revert it. But the fact that we are building this in CI and not hitting it there is suspicious.

Reverted the flags. I think I can narrow the issue down to a small range to debug further.

@Steelskin Steelskin merged commit 228f78a into main Dec 21, 2024
@Steelskin Steelskin deleted the fabrice/devtools-build-swift-lmdb branch December 21, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants