Simplify wix files for SwiftFormat. #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
approved these changes
May 26, 2023
There was a problem hiding this comment.
Congratulations! 🎉 You just became the new WiX expert on the team! Now @compnerd is going to assume you can fix any and all WiX issues 😉.
|
Curious, is there anything that prevents someone on amd64 from installing the arm64 SwiftFormat msi? |
|
@tristanlabelle I think that WI does flag that as incompatible. If not, we should aid it in that. |
compnerd
reviewed
May 26, 2023
Seems like a completely reasonable assumption to me! It is how it works isn't it? 😆 |
Use autogenerated GUIDs. Merge the two wxs files into one.
hjyamauchi
force-pushed
the
SwiftFormatWix
branch
from
c7dce9d to
5bef939
Compare
compnerd
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use autogenerated GUIDs.
Merge the two wxs files into one.