fix(bump): don't fail if an invalid version tag is present (fix #1410) #1418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a regression introduced in the 4.4.0 by #1297:
bump
command is failing when an invalid tag is present and not listed inignored_tags
while it was just warning about before.This PR restores this behavior (bump will work if an invalid tag is present, but a warning will be emitted).
The error/warning message is now the same whatever the place it is triggered.
Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsmaintainedrestoredDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctly (N/A)Expected Behavior
Cf. #1410
Steps to Test This Pull Request
Cf. #1410
Additional Context
Supersedes and closes #1410