Skip to content

fix(bump): don't fail if an invalid version tag is present (fix #1410) #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

noirbizarre
Copy link
Member

Description

Fix a regression introduced in the 4.4.0 by #1297: bump command is failing when an invalid tag is present and not listed in ignored_tags while it was just warning about before.

This PR restores this behavior (bump will work if an invalid tag is present, but a warning will be emitted).

The error/warning message is now the same whatever the place it is triggered.

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained restored
    • Document any manual testing steps performed
  • Update the documentation for the changes (N/A)

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly (N/A)

Expected Behavior

Cf. #1410

Steps to Test This Pull Request

Cf. #1410

Additional Context

Supersedes and closes #1410

@noirbizarre noirbizarre requested review from woile and Lee-W as code owners May 15, 2025 22:58
@noirbizarre noirbizarre changed the title fix(bump): do not fail on when an invalid version tag is present (fix #1410) fix(bump): don't fail if an invalid version tag is present (fix #1410) May 15, 2025
@noirbizarre noirbizarre mentioned this pull request May 15, 2025
4 tasks
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (120d514) to head (82f013c).
Report is 609 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
+ Coverage   97.33%   97.57%   +0.23%     
==========================================
  Files          42       57      +15     
  Lines        2104     2682     +578     
==========================================
+ Hits         2048     2617     +569     
- Misses         56       65       +9     
Flag Coverage Δ
unittests 97.57% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noirbizarre noirbizarre merged commit 46c5ecc into commitizen-tools:master May 16, 2025
18 checks passed
@noirbizarre noirbizarre deleted the fix/invalid-tags branch May 16, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants