refactor(git,init): code cleanup #1417
Open
+471
−313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
force-pushed
the
refactor-git
branch
2 times, most recently
from
afe52aa to
aa57ab1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
+ Coverage 97.33% 98.25% +0.91%
==========================================
Files 42 57 +15
Lines 2104 2637 +533
==========================================
+ Hits 2048 2591 +543
+ Misses 56 46 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
refactor-git
branch
from
aa57ab1 to
403febf
Compare
noirbizarre
reviewed
May 15, 2025
There was a problem hiding this comment.
Good cleanup, thanks!
For the f-string remark, I'll let @Lee-W decide
Lee-W
reviewed
May 16, 2025
bearomorphism
force-pushed
the
refactor-git
branch
from
403febf to
a3a5ca0
Compare
bearomorphism
commented
May 16, 2025
Comment on lines
-44
to
+46
| 'version = "0.0.1"\n' | ||
| "update_changelog_on_bump = true\n" | ||
| "major_version_zero = true\n" | ||
| 'version = "0.0.1"\n' |
There was a problem hiding this comment.
Not sure whether the order is important. If so, I think we can enforce the order somewhere.
bearomorphism
force-pushed
the
refactor-git
branch
4 times, most recently
from
81f0034 to
08a1aa3
Compare
bearomorphism
changed the title
|
It seems that some lines are not covered before this PR change. I'll try to cover them. |
bearomorphism
force-pushed
the
refactor-git
branch
from
08a1aa3 to
5a7fad0
Compare
|
Just vibe tested the changes. |
bearomorphism
commented
May 16, 2025
commitizen/commands/init.py
Outdated
| @@ -67,10 +71,10 @@ def is_php_composer(self) -> bool: | |||
| def latest_tag(self) -> str | None: | |||
| return get_latest_tag_name() | |||
|
|
|||
| def tags(self) -> list | None: | |||
| def tags(self) -> list[str]: | |||
| """Not a property, only use if necessary""" | |||
| if self.latest_tag is None: | |||
There was a problem hiding this comment.
The expression here is always false. I'll consider removing the function for simplicity.
bearomorphism
force-pushed
the
refactor-git
branch
2 times, most recently
from
214be08 to
d27ab71
Compare
bearomorphism
force-pushed
the
refactor-git
branch
2 times, most recently
from
cee142b to
2a7e8ed
Compare
|
Finally passed codecov/patch check... |
bearomorphism
force-pushed
the
refactor-git
branch
3 times, most recently
from
5538439 to
5f0faae
Compare
bearomorphism
force-pushed
the
refactor-git
branch
from
5f0faae to
9430778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EOLTypes. I think it's unnecessary.map.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context