Skip to content

Reinstate network-bsd #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Conversation

lukel97
Copy link
Contributor

@lukel97 lukel97 commented Nov 25, 2019

As well as some packages that depended on it. This is not a complete list though.

Checklist:

  • Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • At least 30 minutes have passed since uploading to Hackage

  • On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, and $version with the version of the package you want to get into Stackage):

    stack unpack $package-$version  # $version is optional
    stack init --resolver nightly
    stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
    

@lukel97
Copy link
Contributor Author

lukel97 commented Nov 25, 2019

cc @ndmitchell

@juhp
Copy link
Contributor

juhp commented Nov 25, 2019

I think you forgot to leave network-bsd added (ie you removed it completely).
(Noting also that Stackage no longer pulls in deps by itself.)

As well as some packages that depended on it. This is not a complete
list though.
@lukel97 lukel97 force-pushed the reinstate-network-bsd branch from e631a3e to 3d492cd Compare November 25, 2019 20:25
@lukel97
Copy link
Contributor Author

lukel97 commented Nov 25, 2019

@juhp thanks, I wasn't sure where the right place to put it was so I just left it out

@lukel97
Copy link
Contributor Author

lukel97 commented Nov 25, 2019

@juhp As an aside, do you know what the terminology "grandfathered dependency" means? I haven't been able to find any mention or reference of it elsewhere

@lukel97
Copy link
Contributor Author

lukel97 commented Nov 25, 2019

Looks like travis-ci is failing because of two unrelated hackage updates that snuck in today

@juhp
Copy link
Contributor

juhp commented Nov 26, 2019

I think grandfathered means they don't have a owner in Stackage basically.
It would be better to take ownership if possible, since adding such Stackage "orphaned" packages is not really encouraged.

@juhp juhp merged commit a7e35b8 into commercialhaskell:master Nov 26, 2019
@juhp
Copy link
Contributor

juhp commented Nov 26, 2019

Merged anyway, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants