Instrumentation for trace profiling #5260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethercrow
force-pushed
the
opentelemetry
branch
3 times, most recently
from
05551ec to
284c2bb
Compare
ethercrow
changed the title
|
I'm not familiar with opentelemetery. Is there some impact of this on normal users of Stack? Also, there's a merge conflict with |
There should be none. Time overhead from this instrumentation is on an order of microsecond per instrumented span. |
|
A fresh screenshot
|
|
Looks like some stack.yaml updates are needed, please see the build failures. |
|
There are still build failures from stack.yaml issues |
|
@ethercrow, are you able to get this pull request to pass the CI checks? |
|
I am not, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes you can run stack with
+RTS -land then inspect the produced eventlog in trace profiling tools, it looks like this:or this:
The second picture makes you wonder why there is a 85 millisecond long GC before even starting the build.