Skip to content

Refactor: Standard filesystem management for input. #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Symbiomatrix
Copy link

@Symbiomatrix Symbiomatrix commented Apr 11, 2025

I do not see any reason why input should be loaded directly in the nodes rather than call the existing get filenames system. I have a mod which allows custom sorting and it's awkward having to override these classes as well.

Also, I'm not sure why files aren't limited to just image / video file extensions? At the very least loadimage should constrain these. But since this is a refactor I've left it as is (wrote a few common types I can remember in a comment).
Edit: Christian addressed this point in his pr, I've altered the code to fit.

@christian-byrne
Copy link
Contributor

christian-byrne commented Apr 11, 2025

@Symbiomatrix Can you take a look at #7573 as an alternative solution?

@Symbiomatrix
Copy link
Author

Symbiomatrix commented Apr 11, 2025

@christian-byrne That's actually unrelated to this PR - still collects and sorts the files directly rather than rely on get method.
But as far as my second comment, it's a good solution, which I see is already in use in LoadAudio.
If we simply run this after get_filenames, would be fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants