Refactor: Standard filesystem management for input. #7571
+14
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not see any reason why input should be loaded directly in the nodes rather than call the existing get filenames system. I have a mod which allows custom sorting and it's awkward having to override these classes as well.
Also, I'm not sure why files aren't limited to just image / video file extensions? At the very least loadimage should constrain these. But since this is a refactor I've left it as is (wrote a few common types I can remember in a comment).
Edit: Christian addressed this point in his pr, I've altered the code to fit.