Fix intellij scalac settings

[hwielenberg]

This fixes an issue that the translation from mill module names to intelliJ module names sometimes uses . as a delimiter and sometimes -. Which causes intelliJ not to be able to link certain settings to the module.

The issue was that at one point all Segment.Cross were translated into Segment.Label. And those two use a different delimiter.

  def moduleName(p: Segments): String =
    p.value
      .foldLeft(new StringBuilder()) {
        case (sb, Segment.Label(s)) if sb.isEmpty => sb.append(s)
        case (sb, Segment.Cross(s)) if sb.isEmpty => sb.append(s.mkString("-"))
        case (sb, Segment.Label(s)) => sb.append(".").append(s)
        case (sb, Segment.Cross(s)) => sb.append("-").append(s.mkString("-"))
      }
      .mkString
      .toLowerCase()

This fix might be quite intrusive for existing projects as it renames the actual modules. The intended delimiter - was not used in most places. This could be avoided by using the delimiter . for cross modules as well.

I tested it with this setup. (Are there any automated tests for genIdea?)

[hwielenberg]

I probably should have started with a fix for the main branch and not with a backport for 0.12 🤦

[lihaoyi]

@hwielenberg you can run the gen-idea tests via ./mill 'integration.ide[gen-idea].packaged.daemon'

[hwielenberg]

This has always used a -

[hwielenberg]

The fix changes this and the file name itself from moduleg.2.12.5.iml to moduleg-2.12.5.iml

[hwielenberg]

Is there a way to get the path to COURSIER_HOME in the test that works in all environments?

//running on ci
<plugin path="/home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala3-compiler_3/3.7.0/scala3-compiler_3-3.7.0.jar"/>
// running locally
<plugin path="/Users/henning.wielenberg/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala3-compiler_3/3.7.0/scala3-compiler_3-3.7.0.jar"/>

//Instead of using
<plugin path="<!-- IGNORE -->org/scala-lang/scala3-compiler_3/3.7.0/scala3-compiler_3-3.7.0.jar"/>
//I'd rather do 
<plugin path="$$COURSIER_HOME$$org/scala-lang/scala3-compiler_3/3.7.0/scala3-compiler_3-3.7.0.jar"/>
expected.replace("$$COURSIER_HOME$$", coursierHome())

[lefou]

Looks good to me. Please mark this as "ready for review" once you are done with refining.