Skip to content

Node upgrade failing for v14+ on adding addition Node Version for CI #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 11.x, 12.x, 13.x]
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x]

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/npmpublish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- v0.1.*
- v0.2.*
- v0.*.*
- v1.*.*

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion src/utilities/utilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default class Utilities {
else
Logger.warn(thisRef, `File already exists: ${chalk.green(filePath)}, ${chalk.yellow('overriding content')}`) // this will output error and exit command

fs.writeFileSync(filePath, string)
fs.writeFileSync(filePath, string.toString())

if (string !== '') // this condition comes for truncating
Logger.success(thisRef, `output written to file: ${chalk.green(filePath)}`) // this will output error and exit command
Expand Down
19 changes: 15 additions & 4 deletions test/resources/scripts/pr_helper.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,26 @@ PR=159
# checkout pr
gh pr checkout $PR


git pull origin release/release-v0.x
# npm install
npm install

#COMMIT

git push
# GIT PUSH and then checks ( validate )
# watching checks running
watch -n 3 "gh pr checks $PR"

#watch -n 3 "gh pr checks $PR"
watch -n 3 "
gh pr checks $PR; echo '---------------';
echo 'PENDING:'
gh pr checks $PR | grep -o pend | wc -w;
echo
echo 'PASSED:'
gh pr checks $PR | grep -o pass | wc -w;
echo
echo 'FAILED:'
gh pr checks $PR | grep -o fail | wc -w;
";
#MERGE PR
gh pr merge $PR -d -m