Add tests for S3OptimizedUploadStorage

Author: drakon

s3file/storages.py

@@ -8,6 +8,8 @@
 from django.core.files.storage import FileSystemStorage, default_storage
 from django.utils._os import safe_join
 
+from s3file.storages_optimized import S3OptimizedUploadStorage
+
 
 class S3MockStorage(FileSystemStorage):
     @property
@@ -52,6 +54,24 @@ class bucket:
         name = "test-bucket"
 
 
+class S3OptimizedMockStorage(S3OptimizedUploadStorage):
+    created_objects = {}
+
+    class bucket:
+        name = "test-bucket"
+
+        class Object:
+            def __init__(self, key):
+                self.key = key
+                self.copy_from_bucket = None
+                self.copy_from_key = None
+                S3OptimizedMockStorage.created_objects[self.key] = self
+
+            def copy(self, s3_object, ExtraArgs):
+                self.copy_from_bucket = s3_object["Bucket"]
+                self.copy_from_key = s3_object["Key"]
+
+
 local_dev = isinstance(default_storage, FileSystemStorage)
 
 storage = default_storage if not local_dev else S3MockStorage()

tests/test_storages.py

@@ -0,0 +1,37 @@
+import pytest
+
+from django.core.files.base import ContentFile
+
+from s3file import storages
+
+
+class TestStorages:
+    url = "/__s3_mock__/"
+
+    def test_post__save_optimized(self):
+        storage = storages.S3OptimizedMockStorage()
+        obj = storage.bucket.Object("tmp/s3file/s3_file.txt")
+
+        class Content:
+            def __init__(self, obj):
+                self.obj = obj
+
+        content = Content(obj)
+        key = storage._save("tmp/s3file/s3_file_copied.txt", content)
+        stored_object = storage.created_objects[
+            "custom/location/tmp/s3file/s3_file_copied.txt"
+        ]
+
+        assert key == "tmp/s3file/s3_file_copied.txt"
+        assert stored_object.copy_from_bucket == storage.bucket.name
+        assert stored_object.copy_from_key == "tmp/s3file/s3_file.txt"
+
+    def test_post__save_optimized_fail(self):
+        storage = storages.S3OptimizedMockStorage()
+
+        with pytest.raises(RuntimeError) as excinfo:
+            storage._save("tmp/s3file/s3_file_copied.txt", ContentFile(b"s3file"))
+
+        assert "The content object must be a S3 object and contain a valid key." in str(
+            excinfo.value
+        )