Skip to content

Detect ES6 module and CommonJS files #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2020
Merged

Detect ES6 module and CommonJS files #136

merged 3 commits into from
Aug 31, 2020

Conversation

matfax
Copy link
Contributor

@matfax matfax commented Aug 31, 2020

As described in the NodeJS documentation, .mjs and .cjs files are also valid JS.
ESM import library detection is already implemented.

@peti2001 peti2001 merged commit 78db924 into codersrank-org:master Aug 31, 2020
@peti2001
Copy link
Collaborator

Thanks for your contribution.

@matfax matfax deleted the patch-1 branch August 31, 2020 20:16
@peti2001
Copy link
Collaborator

Hi @matfax,

We are planning to rewrite the repo_info_extractor. I collected the plans here #160, feel free to share your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matfax @peti2001