Skip to content

[speedfix] Ignore all files and folders .gitignore while copying #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

spasma
Copy link
Contributor

@spasma spasma commented Apr 1, 2020

Hi CodersRank, 👋

I really like your service. I've made some changes to the repo extractor, I've found out that when copying the files to the temporary directory, it also copies (for example in node projects) 'node_modules' and other large non-repo files..

For example:
Without my fix an Angular project is busy for 4 minutes.
With my fix it's done in 5 seconds due to not copying the node_modules.

Hope you like it and keep safe,
Sebastiaan

PS: I'm not a Python developer, so the code may not comply with Python coding guidelines.

@peti2001
Copy link
Collaborator

peti2001 commented Apr 2, 2020

Thanks for your contribution.

@peti2001 peti2001 merged commit 42bed9e into codersrank-org:master Apr 2, 2020
@peti2001
Copy link
Collaborator

Hi @spasma,

We are planning to rewrite the repo_info_extractor. I collected the plans here #160, feel free to share your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants