Skip to content

Add Yii2 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Add Yii2 #76

merged 2 commits into from
Sep 1, 2020

Conversation

glpzzz
Copy link
Contributor

@glpzzz glpzzz commented Aug 31, 2020

No description provided.

libraries.json Outdated
@@ -851,7 +851,7 @@
"language": "C#"
},
"Yii": {
"imports": ["yii\\", "yiisoft/yii"],
"imports": ["yii\\", "yiisoft/yii", "yiisoft/yii2"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to add Yii2 as a new library instead of merging with Yii V1. As I know these two are quite different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@peti2001 peti2001 merged commit 2d4247c into codersrank-org:master Sep 1, 2020
@peti2001
Copy link
Contributor

peti2001 commented Sep 1, 2020

Thanks for your contribution.

@peti2001
Copy link
Contributor

Hi @glpzzz,

We are planning to rewrite the repo_info_extractor. If you have tried it before please have a look at our plans and feel free to share your thoughts codersrank-org/repo_info_extractor#160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants