Skip to content

fix: release notes formatting #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

fix: release notes formatting #27

merged 2 commits into from
Mar 10, 2025

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Mar 10, 2025 •
edited
Loading

  • gh cli (gh release create) does not need \n and \r to be encoded as it should correctly interpret raw newlines from files.
  • also make zip available to download from draft release as it is easier to find

fioan89 added 2 commits March 10, 2025 22:27
@fioan89
fix: release notes formatting
8426e97 
- gh cli (gh release create) does not need \n and \r to be encoded
  as it should correctly interpret raw newlines from files.
@fioan89
fix: make zip available to download from draft release
5ca5d99 
- easier to find
- needs to download artifacts uploaded in the build job
@fioan89 fioan89 requested review from matifali and bcpeinhardt March 10, 2025 21:09
@fioan89 fioan89 marked this pull request as ready for review March 10, 2025 21:10
matifali
matifali approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

@fioan89 fioan89 merged commit 2c8014b into main Mar 10, 2025
5 checks passed
@fioan89 fioan89 deleted the fix-release-draft-workflow-step branch March 10, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

@bcpeinhardt bcpeinhardt Awaiting requested review from bcpeinhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fioan89 @matifali