Skip to content

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Dec 13, 2024

Cleanup PR to:

  • Handle error responses from SDK, improve the error handling
  • Replace the login flow errors with a popup, so we can actually display the full error
  • Update ViewInspector and fix a deprecation warning in the tests
image

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review December 13, 2024 02:38
Copy link
Collaborator

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions inline, but I don't need to review again.

@ethanndickson ethanndickson merged commit b338777 into main Dec 16, 2024
1 check passed
@ethanndickson ethanndickson deleted the ethan/api-errs branch January 23, 2025 02:48
@ethanndickson ethanndickson self-assigned this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants