Skip to content

Add no_proxy support #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Jan 3, 2022 · 3 comments
Closed

Add no_proxy support #4672

jsjoeio opened this issue Jan 3, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 3, 2022

Our proxy patch is missing in VS Code but I am not sure if we need it...they do already support http_proxy and https_proxy (for extensions using the api) but not no_proxy so it could be a breaking change

@code-asher noticed we were missing patches to support HTTP proxies in VS Code. We're going to fix this because we believe it is used by some community and enterprise members.

edit by @code-asher: I thought there was API for extensions to make requests but I actually cannot find it so we will need the patch to support HTTP proxies at all.

@jsjoeio jsjoeio added the bug Something isn't working label Jan 3, 2022
@jsjoeio jsjoeio added this to the 4.0.1 milestone Jan 3, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 3, 2022

@code-asher after that PR is merged into vscode, we probably want to bump the version in code-server. Happy to own that.

@code-asher code-asher changed the title Missing no_proxy patch after VS Code upgrade Missing HTTP proxy patch after VS Code upgrade Jan 3, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 3, 2022

no_proxy does not seem to work but I tested previous versions and trying to use a proxy causes an infinite loop so...it was already broken. Maybe we can patch support in for no_proxy but we have to find where this happens first. In any case the current state is an improvement over infinite loops.

coder/vscode#36 (comment)

@jsjoeio jsjoeio modified the milestones: 4.0.1, 4.1.0 - improve iPad UX Jan 3, 2022
@code-asher code-asher changed the title Missing HTTP proxy patch after VS Code upgrade Add no_proxy support Jan 3, 2022
@stale
Copy link

stale bot commented Jul 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Jul 3, 2022
@stale stale bot closed this as completed Jul 8, 2022
@code-asher code-asher removed the stale label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants