Address code-review

* Change loop to indexed `for` loop
* Moved isDirectory check to IsDir local func, to prevent continue in loop and messy try/catch
* Cleaned up white space issue with patch

Author: shayne

ci/dev/vscode.patch

@@ -1296,7 +1296,8 @@ index 0000000000..16ed214d94
 +	type: 'cli';
 +	args: Args;
 +}
-+ export interface OpenCommandPipeArgs {
++
++export interface OpenCommandPipeArgs {
 +	type: 'open';
 +	fileURIs?: string[];
 +	folderURIs: string[];
@@ -1306,7 +1307,7 @@ index 0000000000..16ed214d94
 +	gotoLineMode?: boolean;
 +	forceReuseWindow?: boolean;
 +	waitMarkerFilePath?: string;
-+ }
++}
 +
 +export type CodeServerMessage = InitMessage | SocketMessage | CliMessage;
 +

src/node/entry.ts

@@ -171,26 +171,35 @@ async function entry(): Promise<void> {
     const pipeArgs: OpenCommandPipeArgs = { type: "open", folderURIs: [] }
     pipeArgs.forceReuseWindow = args["reuse-window"]
     pipeArgs.forceNewWindow = args["new-window"]
-    for (const a in args._) {
-      if (Object.prototype.hasOwnProperty.call(args._, a)) {
-        try {
-          const fp = await fs.realpath(args._[a])
-          const st = await fs.stat(fp)
-          if (st.isDirectory()) {
-            pipeArgs.folderURIs = [...pipeArgs.folderURIs, fp]
-          } else {
-            pipeArgs.fileURIs = [...(pipeArgs.fileURIs || []), fp]
-          }
-        } catch (error) {
-          pipeArgs.fileURIs = [...(pipeArgs.fileURIs || []), args._[a]]
+    const isDir = async (path: string): Promise<boolean> => {
+      try {
+        const st = await fs.stat(path)
+        return st.isDirectory()
+      } catch (error) {
+        return false
+      }
+    }
+    for (let i = 0; i < args._.length; i++) {
+      const fp = path.resolve(args._[i])
+      if (await isDir(fp)) {
+        pipeArgs.folderURIs.push(fp)
+      } else {
+        if (!pipeArgs.fileURIs) {
+          pipeArgs.fileURIs = []
         }
+        pipeArgs.fileURIs.push(fp)
       }
     }
     if (pipeArgs.forceNewWindow && pipeArgs.fileURIs && pipeArgs.fileURIs.length > 0) {
       logger.error("new-window can only be used with folder paths")
       process.exit(1)
     }
-    const vscode = http.request({
+    if (pipeArgs.folderURIs.length === 0 && (!pipeArgs.fileURIs || pipeArgs.fileURIs.length === 0)) {
+      logger.error("open-in expects at least one file or folder argument")
+      process.exit(1)
+    }
+    const vscode = http.request(
+      {
         path: "/",
         method: "POST",
         socketPath: process.env["VSCODE_IPC_HOOK_CLI"],