Skip to content

chore(#89): allow specifying pod port #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

anael-l
Copy link
Contributor

@anael-l anael-l commented Mar 3, 2025

closes #89

As the service port is 80 by default, this does not changes the default port.

Copy link

github-actions bot commented Mar 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@anael-l
Copy link
Contributor Author

anael-l commented Mar 3, 2025

I have read the CLA Document and I hereby sign the CLA

@code-asher
Copy link
Member

Thank you! Does this need a default or does .Values.service.port always have a value?

@anael-l
Copy link
Contributor Author

anael-l commented Mar 6, 2025

Your values file specifies the port 80 on line 42 so that will be the default value

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh thanks for that, I know next to nothing about Helm. That makes sense. Thanks again!

@code-asher code-asher merged commit 72e1812 into coder:main Mar 7, 2025
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@anael-l anael-l deleted the helm-port branch April 16, 2025 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart server port
2 participants