Merge pull request #13 from codelathe/feature/admin_deletegroup_fix_for_admin_addnewgroup

Added admin_deletegroup, fixed admin_createnewgroup

Author: krzysztofFC

filecloudapi/fcserver.py

@@ -1979,7 +1979,7 @@ def admin_createnewgroup(self, groupname: str):
             {"op": "addgroup", "groupname": groupname},
         )
 
-        if int(resp.findtext("./group/groupname", "0")) != 1:
+        if resp.findtext("./group/groupname") is None:
             raise ServerError("", "Failed to create group")
 
     def admin_groupisinshare(
@@ -2367,3 +2367,18 @@ def get_share_activities(self, share: FCShare) -> list[ShareActivity]:
                 entries.append(shares_acts)
 
         return entries
+
+    def admin_deletegroup(self, groupid: str) -> bool:
+        """
+        Delete a user group
+        """
+        resp = self._api_call(
+            "/admin/deletegroup",
+            {"op": "deletegroup", "groupid": groupid},
+        )
+
+        result = resp.findtext("./command/result")
+        if result == "0":
+            return True
+        else:
+            return False

pyproject.toml

@@ -1,7 +1,7 @@
 [tool.poetry]
 
 name = "filecloudapi-python"
-version = "0.4.3"
+version = "0.4.4"
 description = "A Python library to connect to a Filecloud server"
 
 packages = [{ include = "filecloudapi" }]