Skip to content

fixes #127: ability to disable desktop notifications #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2017
Merged

fixes #127: ability to disable desktop notifications #128

merged 2 commits into from
Oct 26, 2017

Conversation

resurtm
Copy link
Contributor

@resurtm resurtm commented Oct 25, 2017

Please check details at #127

README.md Outdated
@@ -44,6 +44,7 @@ Options
--certFile value TLS Certificate
--keyFile value TLS Certificate Key
--logPrefix value Setup custom log prefix
--disableNotifications disable desktop notifications
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resurtm can we actually make desktop notifications disabled by default (and add a flag to enable them)?

@ibash
Copy link
Collaborator

ibash commented Oct 25, 2017

@resurtm other than reversing the default behavior, I'd be happy to merge this :)

@resurtm
Copy link
Contributor Author

resurtm commented Oct 26, 2017

@ibash Thanks! Done.

@glutamatt
Copy link

I built your branch : thanks dude, you saved my notification stack ! 👍

@ibash ibash merged commit cafe2ce into codegangsta:master Oct 26, 2017
cgxxv pushed a commit to cgxxv/gen that referenced this pull request Mar 25, 2022
fixes codegangsta#127: ability to disable desktop notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants