fix(appset): generated app errors should use the default requeue (argoproj#21887) (#390)

* fix(appset): generated app errors should use the default requeue (argoproj#21887) (argoproj#21936)

Signed-off-by: rumstead <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>

* Revert "fix(appset): generated app errors should use the default requeue (argoproj#21887) (argoproj#21936)"

This reverts commit 757c773.

* fix(appset): generated app errors should use the default requeue (argoproj#21887) (argoproj#21936)

Signed-off-by: rumstead <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: rumstead <[email protected]>
Co-authored-by: rumstead <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>

Author: 4 people

applicationset/controllers/applicationset_controller.go

@@ -155,6 +155,7 @@ func (r *ApplicationSetReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 	// desiredApplications is the main list of all expected Applications from all generators in this appset.
 	desiredApplications, applicationSetReason, err := template.GenerateApplications(logCtx, applicationSetInfo, r.Generators, r.Renderer, r.Client)
 	if err != nil {
+		logCtx.Errorf("unable to generate applications: %v", err)
 		_ = r.setApplicationSetStatusCondition(ctx,
 			&applicationSetInfo,
 			argov1alpha1.ApplicationSetCondition{
@@ -164,7 +165,8 @@ func (r *ApplicationSetReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 				Status:  argov1alpha1.ApplicationSetConditionStatusTrue,
 			}, parametersGenerated,
 		)
-		return ctrl.Result{RequeueAfter: ReconcileRequeueOnValidationError}, err
+		// In order for the controller SDK to respect RequeueAfter, the error must be nil
+		return ctrl.Result{RequeueAfter: ReconcileRequeueOnValidationError}, nil
 	}
 
 	parametersGenerated = true

applicationset/controllers/applicationset_controller_test.go

@@ -1885,7 +1885,7 @@ func TestRequeueGeneratorFails(t *testing.T) {
 	}
 
 	res, err := r.Reconcile(context.Background(), req)
-	require.Error(t, err)
+	require.NoError(t, err)
 	assert.Equal(t, ReconcileRequeueOnValidationError, res.RequeueAfter)
 }