fix: inform user when there is no delete request is configured (#3525)

Author: kobenguyent

lib/helper/ApiDataFactory.js

@@ -230,7 +230,7 @@ class ApiDataFactory extends Helper {
   }
 
   _after() {
-    if (!this.config.cleanup) {
+    if (!this.config.cleanup || this.config.cleanup === false) {
       return Promise.resolve();
     }
     const promises = [];
@@ -244,7 +244,6 @@ class ApiDataFactory extends Helper {
         promises.push(this._requestDelete(factoryName, createdItems[id]));
       }
     }
-
     return Promise.all(promises);
   }
 
@@ -379,7 +378,9 @@ Current file error: ${err.message}`);
 
     if (!request) {
       const method = Object.keys(this.factories[factory].delete)[0];
+
       const url = this.factories[factory].delete[method].replace('{id}', id);
+
       request = {
         method,
         url,
@@ -388,6 +389,10 @@ Current file error: ${err.message}`);
 
     request.baseURL = this.config.endpoint;
 
+    if (request.url.match(/^undefined/)) {
+      return this.debugSection('Please configure the delete request in your ApiDataFactory helper', 'delete: () => ({ method: \'DELETE\',  url: \'/api/users\' })');
+    }
+
     return this.restHelper._executeRequest(request).then(() => {
       const idx = this.created[factory].indexOf(id);
       this.debugSection('Deleted Id', `Id: ${id}`);