Split PayloadGeneratorTests into multiple files #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebude
approved these changes
Jun 29, 2024
Collaborator
|
Looks good to me. Thanks! |
Collaborator
|
@Shane32 do you plan any further PRs that should be part of v1.6? Otherwise I would release 1.6 this weekend. |
Owner
Author
|
No. Sounds great; go ahead. |
Owner
Author
|
Unless you want me to write a pr that changes the bmp writer to make 1-bit images with indexed color like the png one does instead of 24-bit uncompressed images. The generated image files would be much smaller. |
Collaborator
|
That sounds like a great idea. But we can also implement it in a 1.6.1/1.7.0 (or if nothing else is on the roadmap) in a 2.0. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test cleanup. Splits PayloadGeneratorTests into multiple files just like how the generator code was broken into multiple files. No changes to tests.