Changes in compiler cached objects deletetion Actions (Sensiolabs) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These Controller actions are much bigger than they should be, and so the main logic should go to a Handler. Initial implementation for the 1st one (untelsted)
Moved code to DeletionHandler Service
If the object files dir wasn't opened, opendir echoes a Warning (probably depends on PHP settings), which would break our JSON. Fixed that
- Added brackets to flow control statements - Replaced upper-case null with lower-case null
- Removed variables passed by reference, made all methods return from a single point - camelCased variables, except for $auth_key, which is already changed on the master branch. - Made braces follow PSR-2 - Removed unnecessary else statements - Changed all double quotes to single quotes in strings
…etionaction-fixes Had to completely remove the composer.lock file and run composer update
… Symfony by composer)
…unnecessary logs)
|
All good. Merging the PR to dev |
fpapadopou
added a commit
that referenced
this pull request
Jul 24, 2015
…ction-fixes Changes in compiler cached objects deletetion Actions (Sensiolabs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Sensiolabs Insights warnings caused by the fact the the deletion actions (delete all objects, or delete the cached objects of a specific core, or delete the cached objects of a specific library) were to long and had to be simplified, migrating most of their code into a new Handler called DeletionHandler.