Skip to content

Fixing SensioLabs' Insight warnings to improve the quality of the code #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6e07cd5
Removed in_memory Security Providers (unused)
tzikis Jan 9, 2015
0f56ce5
Replaced OR operator with || & explicit precedence
tzikis Jan 9, 2015
8a30ae3
Removed unnecessary __FILE__ variables
tzikis Jan 9, 2015
9aeed6c
Added codebender favicon
tzikis Jan 9, 2015
e25959f
Added stricter checks for successful extractions
tzikis Jan 9, 2015
b332d4a
Added stricter checks for successful preprocessing
tzikis Jan 9, 2015
7aa2d68
Deleted Acme Bundle (Symfony2 Demo)
tzikis Jan 9, 2015
cf132dd
Fixed Error due to removal of Acme Bundle
tzikis Jan 9, 2015
01ee571
Fixed 2nd Error due to removal of Acme Bundle
tzikis Jan 9, 2015
7057acc
This should fix the Acme deletion error
tzikis Jan 9, 2015
ae8fab2
Removed dead code
tzikis Jan 9, 2015
885857c
Added 1 more strict bool check
tzikis Jan 9, 2015
13f9500
Renamed a variable for readability
tzikis Jan 9, 2015
ec1d2b7
This should fix all missing ending newlines
tzikis Jan 9, 2015
29eab63
Auto-Formated PreprocessingHandler
tzikis Jan 9, 2015
0ee4557
Auto-Formated UtilityHandler
tzikis Jan 9, 2015
8c57183
Auto-Formated PostProcessingHandler
tzikis Jan 9, 2015
21854c0
Auto-Formated MCUHandler
tzikis Jan 9, 2015
d25ee5a
Auto-Formated DefaultController
tzikis Jan 9, 2015
4260afd
Silenced PHPStorm Warning
tzikis Jan 9, 2015
ff13752
Auto-Formated DefaultControllerTest
tzikis Jan 9, 2015
65d426f
Removed unused Class
tzikis Jan 9, 2015
8b0faee
Auto-Formated CompilerHandler
tzikis Jan 9, 2015
b52fc76
Avoiding using functions in for loop
tzikis Jan 9, 2015
c1b4154
Fixed all PSR-1 Method Naming warnings (hopefuly)
tzikis Jan 9, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Symfony/app/.htaccess
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
deny from all
deny from all

1 change: 0 additions & 1 deletion Symfony/app/AppKernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ public function registerBundles()
);

if (in_array($this->getEnvironment(), array('dev', 'test'))) {
$bundles[] = new Acme\DemoBundle\AcmeDemoBundle();
$bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
$bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();
$bundles[] = new Sensio\Bundle\GeneratorBundle\SensioGeneratorBundle();
Expand Down
4 changes: 0 additions & 4 deletions Symfony/app/config/routing_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ _configurator:

_main:
resource: routing.yml

# AcmeDemoBundle routes (to be removed)
_acme_demo:
resource: "@AcmeDemoBundle/Resources/config/routing.yml"
37 changes: 3 additions & 34 deletions Symfony/app/config/security.yml
Original file line number Diff line number Diff line change
@@ -1,39 +1,8 @@
security:
encoders:
Symfony\Component\Security\Core\User\User: plaintext

role_hierarchy:
ROLE_ADMIN: ROLE_USER
ROLE_SUPER_ADMIN: [ROLE_USER, ROLE_ADMIN, ROLE_ALLOWED_TO_SWITCH]
firewalls:
anonymous:
anonymous: ~

providers:
in_memory:
memory:
users:
user: { password: userpass, roles: [ 'ROLE_USER' ] }
admin: { password: adminpass, roles: [ 'ROLE_ADMIN' ] }

firewalls:
dev:
pattern: ^/(_(profiler|wdt)|css|images|js)/
security: false

login:
pattern: ^/demo/secured/login$
security: false

secured_area:
pattern: ^/demo/secured/
form_login:
check_path: _security_check
login_path: _demo_login
logout:
path: _demo_logout
target: _demo
#anonymous: ~
#http_basic:
# realm: "Secured Demo Area"

access_control:
- { path: ^/demo/secured/hello/admin/, roles: ROLE_ADMIN }
#- { path: ^/login, roles: IS_AUTHENTICATED_ANONYMOUSLY, requires_channel: https }
3 changes: 2 additions & 1 deletion Symfony/src/.htaccess
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
deny from all
deny from all

9 changes: 0 additions & 9 deletions Symfony/src/Acme/DemoBundle/AcmeDemoBundle.php

This file was deleted.

57 changes: 0 additions & 57 deletions Symfony/src/Acme/DemoBundle/Controller/DemoController.php

This file was deleted.

68 changes: 0 additions & 68 deletions Symfony/src/Acme/DemoBundle/Controller/SecuredController.php

This file was deleted.

18 changes: 0 additions & 18 deletions Symfony/src/Acme/DemoBundle/Controller/WelcomeController.php

This file was deleted.

This file was deleted.

24 changes: 0 additions & 24 deletions Symfony/src/Acme/DemoBundle/EventListener/ControllerListener.php

This file was deleted.

20 changes: 0 additions & 20 deletions Symfony/src/Acme/DemoBundle/Form/ContactType.php

This file was deleted.

12 changes: 0 additions & 12 deletions Symfony/src/Acme/DemoBundle/Resources/config/routing.yml

This file was deleted.

18 changes: 0 additions & 18 deletions Symfony/src/Acme/DemoBundle/Resources/config/services.xml

This file was deleted.

Loading