feat: allow ci files to be partials so they can be extended #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us some more flexibility without breaking linting, and the base template is still required to be included.
|
Lint is failing here because of microsoft/TypeScript#56492. Rather than version locking Typescript as downstream projects can manage their own TS versions (<=5.2.2 should work fine), I'll leave this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us some more flexibility without breaking linting, and the base template is still required to be included. In particular this lets us do things like play around with the new deployment CI before needing to reintegrate it back here.
This also resolves an issue with the ci variables not being passed in correctly.