stopWhenComplete，增加动态修改完成时停止方法。 #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sutra
reviewed
Jun 17, 2024
| /** | ||
| * Stop when all tasks in the queue are completed and all worker threads are also completed | ||
| */ | ||
| public void stopWhenComplete(){ |
There was a problem hiding this comment.
增加这个方法是干什么用的？为了让外部调用？系统运行的时候，修改这个变量？
已经有 setExitWhenComplete 了。
There was a problem hiding this comment.
好吧，只是给exitWhenComplete加了个volatile，然后起了个好看点的方法名，其实不改动也能做到，就是看什么时候轮训线程什么时候刷新缓存了。
There was a problem hiding this comment.
我这边的场景是，多个spider协同运行，一开始就把所有spider启动起来，然后在某个时机，比如主要的spider运行的spider执行结束后，手动停止其他的spider，但是又不想丢弃队列中的任务，所以就需要有个方法使得spider在运行完所有任务后停止。就像线程池的shutdown一样
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.