Skip to content

Commit 8d67fd0

Browse files
committed
change back return proxy from spider to httpclientdownloader #128
1 parent 40bf8ca commit 8d67fd0

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

webmagic-core/src/main/java/us/codecraft/webmagic/Spider.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.google.common.collect.Lists;
44
import org.apache.commons.collections.CollectionUtils;
5+
import org.apache.http.HttpHost;
56
import org.slf4j.Logger;
67
import org.slf4j.LoggerFactory;
78
import us.codecraft.webmagic.downloader.Downloader;
@@ -324,6 +325,10 @@ public void run() {
324325
onError(requestFinal);
325326
logger.error("process request " + requestFinal + " error", e);
326327
} finally {
328+
if (site.getHttpProxyPool().isEnable()) {
329+
site.returnHttpProxyToPool((HttpHost) requestFinal.getExtra(Request.PROXY), (Integer) requestFinal
330+
.getExtra(Request.STATUS_CODE));
331+
}
327332
pageCount.incrementAndGet();
328333
signalNewUrl();
329334
}

webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,6 @@ public Page download(Request request, Task task) {
117117
} catch (IOException e) {
118118
logger.warn("close response fail", e);
119119
}
120-
if (site.getHttpProxyPool().isEnable()) {
121-
site.returnHttpProxyToPool((HttpHost) request.getExtra(Request.PROXY), (Integer) request
122-
.getExtra(Request.STATUS_CODE));
123-
}
124120
}
125121
}
126122

0 commit comments

Comments
 (0)