Skip to content

risk tags cmds #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 109 commits into from
Apr 22, 2020
Merged

risk tags cmds #41

merged 109 commits into from
Apr 22, 2020

Conversation

antazoey
Copy link
Contributor

This uses stuff from remove so it's currently targeting that branch

@alanag13 alanag13 changed the base branch from feature/rm-hr to master April 22, 2020 15:34
@alanag13
Copy link
Contributor

@unparalleled-js i changed target branch to master, can you resolve conflicts?

@antazoey antazoey changed the title risk tags cmds [WIP] risk tags cmds Apr 22, 2020
@antazoey antazoey changed the title [WIP] risk tags cmds risk tags cmds Apr 22, 2020

def _handle_list_args(list_arg):
if list_arg and type(list_arg) != list:
return list_arg.split()
Copy link
Contributor

@alanag13 alanag13 Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment explaining why this is necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@antazoey antazoey requested a review from alanag13 April 22, 2020 20:06
Juliya Smith added 2 commits April 22, 2020 20:11
@antazoey antazoey merged commit 3eb66a1 into master Apr 22, 2020
@antazoey antazoey deleted the feature/update-tags branch April 22, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants