Bugfix/defaultp not used #15
Conversation
| @@ -109,7 +111,12 @@ def set_profile(args): | |||
|
|
|||
| def prompt_for_password_reset(args): | |||
| """Securely prompts for your password and then stores it using keyring.""" | |||
| password.set_password_from_prompt(args.profile_name) | |||
| profile = get_profile(args.profile_name) | |||
There was a problem hiding this comment.
This will get the default profile if args.profile_name is None. Thus, profile.name will not be None anymore.
src/code42cli/profile/profile.py
Outdated
| @@ -91,7 +92,8 @@ def show_profile(args): | |||
| print(u"\t* {0} = {1}".format(ConfigAccessor.USERNAME_KEY, profile.username)) | |||
| print(u"\t* {0} = {1}".format(ConfigAccessor.AUTHORITY_KEY, profile.authority_url)) | |||
| print(u"\t* {0} = {1}".format(ConfigAccessor.IGNORE_SSL_ERRORS_KEY, profile.ignore_ssl_error)) | |||
| if password.get_password(args.profile_name) is not None: | |||
| profile_name = profile.name | |||
| if password.get_stored_password(profile_name) is not None: | |||
There was a problem hiding this comment.
This is the reason show profile was inaccurate
|
@alanag13 I changed the dates like we discussed as well |
src/code42cli/profile/profile.py
Outdated
| new_password = password.get_password_from_prompt() | ||
| if not validate_connection(profile.authority_url, profile.username, new_password): | ||
| print_error( | ||
| "Failure to save password. Can't validate username, password, or authority URL." |
There was a problem hiding this comment.
It is unfortunate that this could go wrong for other reasons besides the password not working (until maybe we can distinguish that through custom exceptions?)
By other reasons, I mean like 500 errors.
There was a problem hiding this comment.
I see that you tried to make the message generic but that could be confusing for users in the most common case (the url, password, or username was wrong). I would say something like:
Your password was not saved because your credentials failed to validate. Check your network connection and the spelling of your username and server url.
There was a problem hiding this comment.
Thanks that works and still is generic enough
src/code42cli/profile/profile.py
Outdated
| new_password = password.get_password_from_prompt() | ||
| if not validate_connection(profile.authority_url, profile.username, new_password): | ||
| print_error( | ||
| "Failure to save password. Can't validate username, password, or authority URL." |
There was a problem hiding this comment.
I see that you tried to make the message generic but that could be confusing for users in the most common case (the url, password, or username was wrong). I would say something like:
Your password was not saved because your credentials failed to validate. Check your network connection and the spelling of your username and server url.
| @@ -63,24 +63,24 @@ def _verify_timestamp_order(min_timestamp, max_timestamp): | |||
| raise ValueError(u"Begin date cannot be after end date") | |||
|
|
|||
|
|
|||
| def _parse_timestamp(date_tuple): | |||
| def _parse_timestamp(date_and_time): | |||
There was a problem hiding this comment.
does this method only get called if a min or max timestamp is present? if not, it looks like there would be some problem if date_and_time was None
| @@ -198,9 +207,10 @@ def _verify_args_for_set(args): | |||
| missing_values = not args.c42_username and not args.c42_authority_url | |||
| if missing_values: | |||
| try: | |||
| profile = get_profile(args.profile_name) | |||
| accessor = get_config_accessor() | |||
There was a problem hiding this comment.
@alanag13 This fixed an issue where you would get two error messages when only one made sense during set.. kinda weird to be catching a SystemExit too.
Uh oh!
There was an error while loading. Please reload this page.