[Fizz] Reset Instructions on ResumableState (facebook#33046)

sebmarkbage · web-flow · commit 5dc00d6b2b77 · 2025-04-28T15:50:06.000-04:00
When we end up creating an incomplete state in the shell we end up not
flushing anything. As a hack, in this case we need to reset the
ResumableState because some of the ResumableState is still relevant
(e.g. any preloads that went into headers) but some of the
ResumableState needs to be reset since they assume that what we produced
actually flushed.

We didn't reset the instructions state but we haven't actually flushed
any of the instructions so it needs to reset.
diff --git a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js
@@ -695,6 +695,7 @@ export function resetResumableState(
   resumableState.scriptResources = {};
   resumableState.moduleUnknownResources = {};
   resumableState.moduleScriptResources = {};
+  resumableState.instructions = NothingSent; // Nothing was flushed so no instructions could've flushed.
 }
 
 export function completeResumableState(resumableState: ResumableState): void {

Original file line number	Diff line number	Diff line change
`@@ -695,6 +695,7 @@ export function resetResumableState(`
`695`	`695`	`resumableState.scriptResources = {};`
`696`	`696`	`resumableState.moduleUnknownResources = {};`
`697`	`697`	`resumableState.moduleScriptResources = {};`
	`698`	`+ resumableState.instructions = NothingSent; // Nothing was flushed so no instructions could've flushed.`
`698`	`699`	`}`
`699`	`700`
`700`	`701`	`export function completeResumableState(resumableState: ResumableState): void {`