Update privileges for pcr in v25.2 #19605
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
katmayb
force-pushed
the
privileges-pcr-25.2
branch
from
e70c0e4 to
6189e9e
Compare
katmayb
commented
May 13, 2025
| @@ -200,17 +200,6 @@ Connect to your standby cluster's system virtual cluster using [`cockroach sql`] | |||
| --certs-dir "certs" | |||
| ~~~ | |||
|
|
|||
| 1. Add your cluster organization and [{{ site.data.products.enterprise }} license]({% link {{ page.version.version }}/licensing-faqs.md %}#types-of-licenses) to the cluster: | |||
There was a problem hiding this comment.
Taking this out because of the licensing change. (I should go back through to v24.3 and make sure to remove.)
katmayb
force-pushed
the
privileges-pcr-25.2
branch
from
6189e9e to
e6125ac
Compare
alicia-l2
approved these changes
May 19, 2025
There was a problem hiding this comment.
LGTM except I think we should remove all mention of the SET REPLICATION SOURCE EXPIRATION WINDOW = duration. I think this is too much information for the user and can result in unexpected behavior for the source cluster, which we also don't test. See https://cockroachlabs.slack.com/archives/CJXBR3693/p1747684142786379?thread_ts=1746716551.106479&cid=CJXBR3693
katmayb
force-pushed
the
privileges-pcr-25.2
branch
from
e6125ac to
4582dee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-12796, DOC-13026
Updates the privileges for PCR SQL statements for 25.2.