-
Notifications
You must be signed in to change notification settings - Fork 4k
Description
mvccGCQueue
, when resolving intents, sets a AdmissionHeader
using a gcAdmissionHeader
. An AdmissionHeader
does not include a tenantID since it is supposed to be extracted in Node.Batch
using roachpb.ClientTenantFromContext(ctx)
. AFAIK, we don't provide a context in this case that includes the tenantID of the range. This means the intent resolution will be charged to the system tenant.
For proper inter-tenant isolation, intent resolution in this case should use the range's tenant.
This is motivated by an escalation -- e.g. see thread https://cockroachlabs.slack.com/archives/C081JBE946P/p1732121444459029?thread_ts=1732114829.937389&cid=C081JBE946P
Edit: I've changed the title of this issue. The IntentResolver.irBatcher
which batches requests to a range, does not use the tenant of the range. It is also unclear whether non-batched intent resolution is using the tenant either.
Jira issue: CRDB-44749