Merge #152848 #152850 #152856

152848: release: fix docker image verification with telemetry disabled r=celiala a=rail

This commit fixes the verification of the FIPS docker image when telemetry is disabled.

Epic: none
Release note: none

152850: changefeedccl: ignore context canceled error in tests r=andyyang890 a=KeithCh

Context canceled errors is causing flakes in tests, and should be ignored.

Fixes: #151726 #152510
Release note: None

152856: roachtest: create required test schemas for SQLAlchemy test suite r=rafiss a=rafiss

fixes #152780
fixes #152779
fixes #152778
fixes #152775
fixes #152773

Release note: None

Co-authored-by: Rail Aliiev <[email protected]>
Co-authored-by: Keith Chow <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>

Author: 4 people

build/teamcity/internal/release/process/build-cockroach-release-per-platform.sh

@@ -118,6 +118,6 @@ fi
 # Here we verify the FIPS image only. The multi-arch image will be verified in the job it's created.
 if [[ $platform == "linux-amd64-fips" ]]; then
   tc_start_block "Verify FIPS docker image"
-  verify_docker_image "$build_docker_tag" "linux/amd64" "$BUILD_VCS_NUMBER" "$version" true false
+  verify_docker_image "$build_docker_tag" "linux/amd64" "$BUILD_VCS_NUMBER" "$version" true $telemetry_disabled
   tc_end_block "Verify FIPS docker image"
 fi

pkg/ccl/changefeedccl/helpers_test.go

@@ -938,6 +938,7 @@ func requireNoFeedsFail(t *testing.T) (fn updateKnobsFn) {
 		`connection reset by peer`,
 		`knobs.RaiseRetryableError`,
 		`test error`,
+		`context canceled`,
 	}
 	shouldIgnoreErr := func(err error) bool {
 		if err == nil || errors.Is(err, context.Canceled) {

pkg/cmd/roachtest/tests/sqlalchemy.go

@@ -128,6 +128,22 @@ func runSQLAlchemy(ctx context.Context, t test.Test, c cluster.Cluster) {
 		t.Fatal(err)
 	}
 
+	// The test suite requires two schemas to be created ahead of time.
+	// See https://github.com/sqlalchemy/sqlalchemy/blob/b3feb9cd3e87960ee65968b712e73d8464385a4a/README.unittests.rst?plain=1#L139.
+	db, err := c.ConnE(ctx, t.L(), node[0], option.DBName("defaultdb"))
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer db.Close()
+	for _, cmd := range []string{
+		`CREATE SCHEMA IF NOT EXISTS test_schema`,
+		`CREATE SCHEMA IF NOT EXISTS test_schema_2`,
+	} {
+		if _, err := db.ExecContext(ctx, cmd); err != nil {
+			t.Fatal(err)
+		}
+	}
+
 	blocklistName, expectedFailures := "sqlAlchemyBlocklist", sqlAlchemyBlocklist
 	ignoredlistName, ignoredlist := "sqlAlchemyIgnoreList", sqlAlchemyIgnoreList
 	t.L().Printf("Running cockroach version %s, using blocklist %s, using ignoredlist %s",