Fix a naming mismatch so that container deployments work #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to work as expected - Update docker-compose.yaml to match service component naming so CI build-and-deploy process builds the expected container images and posts them correctly to the dployment webhook. - Update docker-compose.yaml with additional comments. - Update README.md with additional comments on build-and-deploy process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use docker-compose in Actions to build certain services' container images. There is a necessity for a few parts of the service definition to share a similar name. Looks like this was modified at some point, the result being that we were building a container image with one image:tag, and then telling our webhook updater to use a different image:tag. So nothing was being deployed. This PR largely fixes that.
Additionally it adds some comments and bit of extra info in the README about the process.