-
Notifications
You must be signed in to change notification settings - Fork 67
[Prototype] Client-side caching option for Epidata.covidcast Python #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dshemetov
wants to merge
13
commits into
cmu-delphi:dev
Choose a base branch
from
dshemetov:feat_py_epidata_cache
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinandrew
reviewed
May 17, 2021
chinandrew
reviewed
May 19, 2021
chinandrew
reviewed
May 19, 2021
chinandrew
reviewed
May 19, 2021
chinandrew
reviewed
May 19, 2021
Epidata.covidcast('src', 'sig', 'day', 'county', 20200414, '01234') | ||
get.assert_called_once() | ||
post.assert_not_called() | ||
assert call('get') in Session.request.call_args_list() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: check that the length of the call args (number of calls) is correct. otherwise lgtm
Are any of these changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Epidata.covidcast
is idempotent on the hour-scale (I think). This PR adds client-side caching toEpidata.covidcast
in Python, to save user effort in writing their own file saving mechanisms.Example:
The goal is to expose
cache_timeout
to thecovidcast
Python library in another PR. We can keep the default behavior cacheless to remove hidden state issues.Overlapping, but not identical time windows will look to the cache and the web gracefully (because the
covidcast
Python library splits date range requests into dailyEpidata.covidcast
calls). This is not true for geos (but could be if we can provide metadata of available geos per indicator).Changes
Switch to requests_cache when the
cache_timeout
argument is sent.