Skip to content

Tests refactoring #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 37 commits into from
Closed

Conversation

dmytrotsko
Copy link
Contributor

Summary:

Refactored old tests. Changed test's base class.
Added new method to send requests to the DelphiTestBase class

Prerequisites:

  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dmytrotsko dmytrotsko marked this pull request as draft September 28, 2023 20:40
dmytrotsko and others added 27 commits October 2, 2023 17:07
Comments fix

Co-authored-by: melange396 <[email protected]>
Remove unused lib

Co-authored-by: melange396 <[email protected]>
Remove extra newline

Co-authored-by: melange396 <[email protected]>
Removed unnecessary code from setUp and changed it to the localSetUp
…with internal self.epidata_client from the base class.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dmytrotsko dmytrotsko changed the base branch from dev to rzatserkovnyi/api-php-refactor October 3, 2023 13:21
@dmytrotsko dmytrotsko changed the base branch from rzatserkovnyi/api-php-refactor to dev October 3, 2023 13:22
@dmytrotsko dmytrotsko changed the base branch from dev to rzatserkovnyi/api-php-refactor October 10, 2023 12:54
@dmytrotsko dmytrotsko closed this Oct 12, 2023
@melange396
Copy link
Collaborator

replaced by #1307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants