Skip to content

feat: Add support to module 'sre_compile' is deprecated #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zizhengWong
Copy link

@zizhengWong zizhengWong commented Sep 21, 2023

when I run make check-lint, I got

build_support/cpplint.py:52: DeprecationWarning: module 'sre_compile' is deprecated
import sre_compile

this python module has been deprecated

fix bug

sre_* modules like sre_constants, sre_compile, and sre_parse were deprecated in 3.11

I use re._compiler instead, and it works!

reference

python/cpython#105456

@zizhengWong zizhengWong changed the title fix: module 'sre_compile' is deprecated feat: module 'sre_compile' is deprecated Sep 21, 2023
@zizhengWong zizhengWong changed the title feat: module 'sre_compile' is deprecated feat: Addmodule 'sre_compile' is deprecated Sep 21, 2023
@zizhengWong zizhengWong changed the title feat: Addmodule 'sre_compile' is deprecated feat: Add support to module 'sre_compile' is deprecated Sep 21, 2023
@skyzh
Copy link
Member

skyzh commented Sep 21, 2023

make check-lint is no longer required as of Fall 2023 :(

@prashanthduvvada prashanthduvvada added the wontfix This will not be worked on label Aug 9, 2024
@prashanthduvvada
Copy link
Contributor

No longer required, hence closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants