Explicitly cast bool to int to avoid legacy PHP test failures

Author: clue

res/sqlite-worker.php

@@ -134,10 +134,13 @@
         } else {
             $statement = $db->prepare($data->params[0]);
             foreach ($data->params[1] as $index => $value) {
+                // explicitly cast bool to int because SQLite does not have a native boolean
+                $value = ($value === true || $value === false) ? (int)$value : $value;
+
                 $statement->bindValue(
                     $index + 1,
                     $value,
-                    $value === null ? \SQLITE3_NULL : \is_int($value) || \is_bool($value) ? \SQLITE3_INTEGER : \is_float($value) ? \SQLITE3_FLOAT : \SQLITE3_TEXT
+                    $value === null ? \SQLITE3_NULL : \is_int($value) ? \SQLITE3_INTEGER : \is_float($value) ? \SQLITE3_FLOAT : \SQLITE3_TEXT
                 );
             }
             $result = @$statement->execute();
@@ -173,10 +176,13 @@
     } elseif ($data->method === 'query' && $db !== null && \count($data->params) === 2 && \is_string($data->params[0]) && \is_object($data->params[1])) {
         $statement = $db->prepare($data->params[0]);
         foreach ($data->params[1] as $index => $value) {
+            // explicitly cast bool to int because SQLite does not have a native boolean
+            $value = ($value === true || $value === false) ? (int)$value : $value;
+
             $statement->bindValue(
                 $index,
                 $value,
-                $value === null ? \SQLITE3_NULL : \is_int($value) || \is_bool($value) ? \SQLITE3_INTEGER : \is_float($value) ? \SQLITE3_FLOAT : \SQLITE3_TEXT
+                $value === null ? \SQLITE3_NULL : \is_int($value) ? \SQLITE3_INTEGER : \is_float($value) ? \SQLITE3_FLOAT : \SQLITE3_TEXT
             );
         }
         $result = @$statement->execute();

tests/FunctionalDatabaseTest.php

@@ -281,15 +281,21 @@ public function testQueryStringResolvesWithResultWithTypeStringAndRunsUntilQuit(
 
     public function provideSqlDataWillBeReturnedWithType()
     {
-        return [
-            ['42', 42],
-            ['1.5', 1.5],
-            ['null', null],
-            ['"hello"', 'hello'],
-            ['"hellö"', 'hellö'],
-            ['true', 1],
-            ['false', 0],
-        ];
+        return array_merge(
+            [
+                ['42', 42],
+                ['1.5', 1.5],
+                ['null', null],
+                ['"hello"', 'hello'],
+                ['"hellö"', 'hellö']
+            ],
+            (SQLite3::version()['versionNumber'] < 3023000) ? [] : [
+                // boolean identifiers exist only as of SQLite 3.23.0 (2018-04-02)
+                // @link https://www.sqlite.org/lang_expr.html#booleanexpr
+                ['true', 1],
+                ['false', 0]
+            ]
+        );
     }
 
     /**
@@ -308,7 +314,7 @@ public function testQueryValueInStatementResolvesWithResultWithTypeAndRunsUntilQ
         $promise->then(function (DatabaseInterface $db) use (&$data, $value){
             $db->query('SELECT ' . $value . ' AS value')->then(function (Result $result) use (&$data) {
                 $data = $result->rows;
-            });
+            }, 'printf');
 
             $db->quit();
         });
@@ -323,6 +329,7 @@ public function provideDataWillBeReturnedWithType()
         return [
             [0],
             [1],
+            [42],
             [1.5],
             [null],
             ['hello'],
@@ -345,7 +352,7 @@ public function testQueryValuePlaceholderPositionalResolvesWithResultWithExactTy
         $promise->then(function (DatabaseInterface $db) use (&$data, $value){
             $db->query('SELECT ? AS value', array($value))->then(function (Result $result) use (&$data) {
                 $data = $result->rows;
-            });
+            }, 'printf');
 
             $db->quit();
         });
@@ -370,7 +377,7 @@ public function testQueryValuePlaceholderNamedResolvesWithResultWithExactTypeAnd
         $promise->then(function (DatabaseInterface $db) use (&$data, $value){
             $db->query('SELECT :value AS value', array('value' => $value))->then(function (Result $result) use (&$data) {
                 $data = $result->rows;
-            });
+            }, 'printf');
 
             $db->quit();
         });
@@ -385,7 +392,7 @@ public function provideDataWillBeReturnedWithOtherType()
         return [
             'true' => [true, 1],
             'false' => [false, 0],
-            'float without fraction is int' => [1.0, 1]
+            'float without fraction is int' => [2.0, 2]
         ];
     }