Explicitly cast bool to int to avoid legacy PHP test failures

Author: clue

res/sqlite-worker.php

@@ -134,10 +134,24 @@
         } else {
             $statement = $db->prepare($data->params[0]);
             foreach ($data->params[1] as $index => $value) {
+                if ($value === null) {
+                    $type = \SQLITE3_NULL;
+                } elseif ($value === true || $value === false) {
+                    // explicitly cast bool to int because SQLite does not have a native boolean
+                    $type = \SQLITE3_INTEGER;
+                    $value = (int)$value;
+                } elseif (\is_int($value)) {
+                    $type = \SQLITE3_INTEGER;
+                } elseif (\is_float($value)) {
+                    $type = \SQLITE3_FLOAT;
+                } else {
+                    $type = \SQLITE3_TEXT;
+                }
+
                 $statement->bindValue(
                     $index + 1,
                     $value,
-                    $value === null ? \SQLITE3_NULL : \is_int($value) || \is_bool($value) ? \SQLITE3_INTEGER : \is_float($value) ? \SQLITE3_FLOAT : \SQLITE3_TEXT
+                    $type
                 );
             }
             $result = @$statement->execute();
@@ -173,10 +187,24 @@
     } elseif ($data->method === 'query' && $db !== null && \count($data->params) === 2 && \is_string($data->params[0]) && \is_object($data->params[1])) {
         $statement = $db->prepare($data->params[0]);
         foreach ($data->params[1] as $index => $value) {
+            if ($value === null) {
+                $type = \SQLITE3_NULL;
+            } elseif ($value === true || $value === false) {
+                // explicitly cast bool to int because SQLite does not have a native boolean
+                $type = \SQLITE3_INTEGER;
+                $value = (int)$value;
+            } elseif (\is_int($value)) {
+                $type = \SQLITE3_INTEGER;
+            } elseif (\is_float($value)) {
+                $type = \SQLITE3_FLOAT;
+            } else {
+                $type = \SQLITE3_TEXT;
+            }
+
             $statement->bindValue(
                 $index,
                 $value,
-                $value === null ? \SQLITE3_NULL : \is_int($value) || \is_bool($value) ? \SQLITE3_INTEGER : \is_float($value) ? \SQLITE3_FLOAT : \SQLITE3_TEXT
+                $type
             );
         }
         $result = @$statement->execute();

tests/FunctionalDatabaseTest.php

@@ -281,15 +281,21 @@ public function testQueryStringResolvesWithResultWithTypeStringAndRunsUntilQuit(
 
     public function provideSqlDataWillBeReturnedWithType()
     {
-        return [
-            ['42', 42],
-            ['1.5', 1.5],
-            ['null', null],
-            ['"hello"', 'hello'],
-            ['"hellö"', 'hellö'],
-            ['true', 1],
-            ['false', 0],
-        ];
+        return array_merge(
+            [
+                ['42', 42],
+                ['2.5', 2.5],
+                ['null', null],
+                ['"hello"', 'hello'],
+                ['"hellö"', 'hellö']
+            ],
+            SQLite3::version()['versionNumber'] < 3023000 ? [] : [
+                // boolean identifiers exist only as of SQLite 3.23.0 (2018-04-02)
+                // @link https://www.sqlite.org/lang_expr.html#booleanexpr
+                ['true', 1],
+                ['false', 0]
+            ]
+        );
     }
 
     /**