Merge pull request #53 from clue-labs/tests

Add PHPUnit to require-dev

Author: clue

.travis.yml

@@ -17,4 +17,4 @@ install:
   - composer install --no-interaction
 
 script:
-  - phpunit --coverage-text
+  - vendor/bin/phpunit --coverage-text

README.md

@@ -34,6 +34,7 @@ It enables you to set and query its data or use its PubSub topics to react to in
     * [close()](#close)
     * [end()](#end)
 * [Install](#install)
+* [Tests](#tests)
 * [License](#license)
 
 ## Quickstart example
@@ -248,6 +249,21 @@ $ composer require "clue/redis-react:^1.0 || ^0.5"
 
 See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.
 
+## Tests
+
+To run the test suite, you first need to clone this repo and then install all
+dependencies [through Composer](http://getcomposer.org):
+
+```bash
+$ composer install
+```
+
+To run the test suite, go to the project root and run:
+
+```bash
+$ php vendor/bin/phpunit
+```
+
 ## License
 
 MIT

composer.json

@@ -22,6 +22,7 @@
         "psr-4": { "Clue\\React\\Redis\\": "src/" }
     },
     "require-dev": {
-        "clue/block-react": "^1.1"
+        "clue/block-react": "^1.1",
+        "phpunit/phpunit": "^5.0 || ^4.8"
     }
 }

tests/FactoryTest.php

@@ -1,7 +1,5 @@
 <?php
 
-use React\Socket\ConnectionInterface;
-
 use Clue\React\Redis\Factory;
 use React\Promise;
 
@@ -13,8 +11,8 @@ class FactoryTest extends TestCase
 
     public function setUp()
     {
-        $this->loop = $this->getMock('React\EventLoop\LoopInterface');
-        $this->connector = $this->getMock('React\SocketClient\ConnectorInterface');
+        $this->loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
+        $this->connector = $this->getMockBuilder('React\SocketClient\ConnectorInterface')->getMock();
         $this->factory = new Factory($this->loop, $this->connector);
     }
 

tests/FunctionalTest.php

@@ -1,7 +1,6 @@
 <?php
 
 use React\Stream\Stream;
-use React\Stream\ReadableStream;
 use Clue\React\Redis\Factory;
 use Clue\React\Redis\StreamingClient;
 use React\Promise\Deferred;

tests/StreamingClientTest.php

@@ -19,8 +19,8 @@ class StreamingClientTest extends TestCase
     public function setUp()
     {
         $this->stream = $this->getMockBuilder('React\Stream\Stream')->disableOriginalConstructor()->setMethods(array('write', 'close', 'resume', 'pause'))->getMock();
-        $this->parser = $this->getMock('Clue\Redis\Protocol\Parser\ParserInterface');
-        $this->serializer = $this->getMock('Clue\Redis\Protocol\Serializer\SerializerInterface');
+        $this->parser = $this->getMockBuilder('Clue\Redis\Protocol\Parser\ParserInterface')->getMock();
+        $this->serializer = $this->getMockBuilder('Clue\Redis\Protocol\Serializer\SerializerInterface')->getMock();
 
         $this->client = new StreamingClient($this->stream, $this->parser, $this->serializer);
     }

tests/bootstrap.php

@@ -49,7 +49,7 @@ protected function expectCallableOnceParameter($type)
      */
     protected function createCallableMock()
     {
-        return $this->getMock('CallableStub');
+        return $this->getMockBuilder('CallableStub')->getMock();
     }
 
     protected function expectPromiseResolve($promise)