Fix method receivers and error handling in sharedaction/resource.go

[wayneeseguin]

• Add named receivers to 6 methods that had unnamed receivers (Actor)
• Fix error handling for ignore.CompileIgnoreLines() calls (4 occurrences)
• Fix ignored error from ZipDirectoryResources in CreateArchive method

Thank you for contributing to the CF CLI! Please read the following:

• Please make sure you have implemented changes in line with the contributing guidelines
• We're not allowed to accept any PRs without a signed CLA, no matter how small.
  If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
• All new code requires tests to protect against regressions.
• Contributions must be made against the appropriate branch. See the contributing guidelines
• Contributions must conform to our style guide. Please reach out to us if you have questions.

Note: Please create separate PR for every branch (main, v8 and v7) as needed.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

[norman-abramovitz]

Does this need to fixed on the V8 branch as well? It is interfering with ginkgo and go test unit test writing.

`go test cf_targets_test.go

code.cloudfoundry.org/cli/actor/sharedaction

../../../go/pkg/mod/code.cloudfoundry.org/[email protected]/actor/sharedaction/resource.go:441:11: not enough return values
have (*ignore.GitIgnore)
want (*ignore.GitIgnore, error)
../../../go/pkg/mod/code.cloudfoundry.org/[email protected]/actor/sharedaction/resource.go:444:9: not enough return values
have (*ignore.GitIgnore)
want (*ignore.GitIgnore, error)
../../../go/pkg/mod/code.cloudfoundry.org/[email protected]/actor/sharedaction/resource.go:469:9: not enough return values
have (*ignore.GitIgnore)
want (*ignore.GitIgnore, error)
FAIL command-line-arguments [build failed]
FAIL`

[norman-abramovitz]

Here is the ginkgo failure for the same reason.

`ginkgo .
2025/05/27 13:10:01 maxprocs: Leaving GOMAXPROCS=12: CPU quota undefined
Failed to compile cf-targets-plugin:

code.cloudfoundry.org/cli/actor/sharedaction

../../../go/pkg/mod/code.cloudfoundry.org/[email protected]/actor/sharedaction/resource.go:441:11: not enough return values
have (*ignore.GitIgnore)
want (*ignore.GitIgnore, error)
../../../go/pkg/mod/code.cloudfoundry.org/[email protected]/actor/sharedaction/resource.go:444:9: not enough return values
have (*ignore.GitIgnore)
want (*ignore.GitIgnore, error)
../../../go/pkg/mod/code.cloudfoundry.org/[email protected]/actor/sharedaction/resource.go:469:9: not enough return values
have (*ignore.GitIgnore)
want (*ignore.GitIgnore, error)

Ginkgo ran 1 suite in 340.711542ms

Test Suite Failed`

Once I fixed my downloaded code in ~/go/pkg.... I was able to continue writing my unit tests.

[norman-abramovitz]

Confused why ignore.CompileIgnoreLines is not returning two values. I will have to dig deeper into the CLI code.