Skip to content

updates for version 1.0.4 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,13 @@ first with `url.parse()`, there will be a `host` property in the result, so
you won't be able to use the `hostname` and `port` values directly. You
can **ONLY** set the resultant hostname and port with the `host` property.

Note that `url.parse()` and the later `url.format()` calls to construct the
result, will not produce pleasing results for "unusual" URLs, especially
those which do not use `http:` or `https:` protocols. The `url` `parse()`
and `format()` methods will not be used though, if you have no replacement
values, or the only replacement property is `url`, and so are safe to
use in that case.

Since the `appEnv.getServiceURL()` method operates against the
`appEnv.services` property, you can fudge this object if that makes your
life easier.
Expand Down Expand Up @@ -304,6 +311,12 @@ When you visit the site, you'll see the output of various cfenv calls.
changes
================================================================================

**1.0.4** - 2017/01/13

- fix to getServiceURL() with non-http URLs - [issue #21][]

[issue #21]: https://github.com/cloudfoundry-community/node-cfenv/issues/21

**1.0.3** - 2014/10/02

- fixes for compatibility with Diego - [issue #11][]
Expand Down
2 changes: 1 addition & 1 deletion lib-src/cfenv.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ throwError = (message) ->

#-------------------------------------------------------------------------------
# Copyright IBM Corp. 2014
# Copyright Patrick Mueller 2015
# Copyright Patrick Mueller 2015, 2017
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "cfenv",
"main": "./lib/cfenv",
"description": "easy access to your Cloud Foundry application environment",
"version": "1.0.3",
"version": "1.0.4",
"author": "pmuellr",
"license": "Apache-2.0",
"homepage": "https://github.com/cloudfoundry-community/node-cfenv",
Expand Down
2 changes: 1 addition & 1 deletion tests/test-core.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ JL = (object) -> JSON.stringify object, null, 4

#-------------------------------------------------------------------------------
# Copyright IBM Corp. 2014
# Copyright Patrick Mueller 2015
# Copyright Patrick Mueller 2015, 2017
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down